-
Notifications
You must be signed in to change notification settings - Fork 8.1k
mcp: various touch ups #23251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcp: various touch ups #23251
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| behind it from Visual Studio Code. | ||
|
|
||
| To view all the commands and configuration options, go to the [mcp-gateway repository](https://github.com/docker/mcp-gateway?tab=readme-ov-file#usage). | ||
| {{< button url="https://github.com/docker/mcp-gateway?tab=readme-ov-file#usage" text="View the complete docs on GitHub" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we not link to the reference section? And why the fancy button? We don't use a button elsewhere in the manuals section so it'd look a lil' random, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does but these docs are a repeat of what the repo does better and some users have expressed feedback about the lack of docs. I want to make sure we funnel them to the repo instead of duplicating more docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the upstream docs are better, could we consider pulling them into our docs repo with a script rather than directing users away? If we still need to link out to the upstream docs until some automation is in place, could you remove the button? It feels inconsistent with the rest of the section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's automation for something we don't need, we can simply link to things like we do everywhere? I'll remove the button.
Reorder pages in MCP TOC, touch up content, add summary bars, use tabs where appropriate, etc.